Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix mssql integration test #17923

Merged
merged 7 commits into from
Sep 20, 2024
Merged

MINOR: fix mssql integration test #17923

merged 7 commits into from
Sep 20, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Sep 19, 2024 •
edited
Loading

use sql server 2022 due to something like microsoft/mssql-docker#881 or microsoft/mssql-docker#441

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner September 19, 2024 11:38
@sushi30 sushi30 changed the title change tag for sql server due to https://github.com/microsoft/mssql-d… MINOR: change tag for mssql Sep 19, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull
pmbrull previously approved these changes Sep 19, 2024
View reviewed changes
@sushi30 sushi30 changed the title MINOR: change tag for mssql MINOR: fix mssql integration test Sep 19, 2024
@sushi30 sushi30 enabled auto-merge (squash) September 20, 2024 05:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TeddyCr
TeddyCr reviewed Sep 20, 2024
View reviewed changes
ingestion/tests/integration/sql_server/conftest.py
@@ -22,24 +23,55 @@
from ..conftest import ingestion_config as base_ingestion_config


@pytest.fixture(scope="module")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a question on my end. Wouldn't scope=module make it so the fixture would be destroyed at the end of the last test in sql_server/test_lineage.py for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. With containers a best practice is to have session (since its most expensive to setup) level fixtures for the containers and module level fixtures for data entities like databases or tables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for this case the data stays static throughout the tests so its fine like this.

TeddyCr
TeddyCr approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushi30 sushi30 merged commit d09bca2 into main Sep 20, 2024
15 of 16 checks passed
@sushi30 sushi30 deleted the fix-mssql-ci branch September 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushi30 @TeddyCr @pmbrull